Re: [bug fix] pg_ctl always uses the same event source

From: "MauMau" <maumau307(at)gmail(dot)com>
To: "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>
Cc: "Magnus Hagander" <magnus(at)hagander(dot)net>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bug fix] pg_ctl always uses the same event source
Date: 2013-12-20 11:56:58
Message-ID: BC8D0BF2E63D4F5E91DC82FE71C381E3@maumau
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

From: "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>
> Few other points:
> -------------------------
> 1.
> #ifdef WIN32
> /* Get event source from postgresql.conf for eventlog output */
> get_config_value("event_source", event_source, sizeof(event_source));
> #endif
>
> event logging is done for both win32 and cygwin env.
> under hash define (Win32 || cygwin),
> so event source name should also be retrieved for both
> environments. Refer below in code:
>
> #if defined(WIN32) || defined(__CYGWIN__)
> static void
> write_eventlog(int level, const char *line)
>
> 2.
> Docs needs to be updated for default value:
> http://www.postgresql.org/docs/devel/static/event-log-registration.html
> http://www.postgresql.org/docs/devel/static/runtime-config-logging.html#GUC-EVENT-SOURCE

Okay, done. Thanks. I'll update the commitfest entry this weekend.

Regards
MauMau

Attachment Content-Type Size
pg_ctl_eventsrc_v4.patch application/octet-stream 9.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-12-20 12:12:01 Re: preserving forensic information when we freeze
Previous Message Haribabu kommi 2013-12-20 09:13:10 Re: New option for pg_basebackup, to specify a different directory for pg_xlog