| From: | Jaime Casanova <jaime(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: adding a new column in IDENTIFY_SYSTEM |
| Date: | 2011-05-25 02:31:04 |
| Message-ID: | BANLkTinyBfKXyiHoB4nBd007Nyr6e9qasA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 24, 2011 at 8:52 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> + primary_xlp_magic = atoi(PQgetvalue(res, 0, 2));
>
> You wrongly get the third field (i.e., current xlog location) as the
> WAL version.
> You should call PQgetvalue(res, 0, 3), instead.
>
>> errdetail("Expected 1 tuple with 3 fields, got %d tuples with %d fields.",
>
> You need to change the above message.
>
Fixed.
About you comments on the check... if you read the thread, you will
find that the whole reason for the field is future improvement, but
everyone wanted some use of the field now... so i made a patch to use
it in pg_basebackup before the transfer starts and avoid time and
bandwith waste but Magnus prefer this in walreceiver...
--
Jaime Casanova www.2ndQuadrant.com
Professional PostgreSQL: Soporte y capacitación de PostgreSQL
| Attachment | Content-Type | Size |
|---|---|---|
| identify_system_xlogversion_v3.patch | text/x-patch | 8.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Kupershmidt | 2011-05-25 02:31:50 | Re: patch: Allow \dd to show constraint comments |
| Previous Message | Greg Smith | 2011-05-25 01:59:31 | Re: 9.2 schedule |