Re: use less space in xl_xact_commit patch

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Leonardo Francalanci <m_lists(at)yahoo(dot)it>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: use less space in xl_xact_commit patch
Date: 2011-06-16 13:33:47
Message-ID: BANLkTimq1noZ-9tSE7PL5-Tgo-DOfGL68Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 16, 2011 at 2:22 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Jun 16, 2011 at 7:25 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> With regards to the naming, I think it would be better if we kept
>> XLOG_XACT_COMMIT record exactly as it is now, and make the second
>> record an entirely new record called XLOG_XACT_COMMIT_FASTPATH. That
>> way we retain backwards compatibility.
>
> I liked your previous suggestion of commit and commit-with-info
> better.  There's nothing particularly fast about this; it's just less
> info.  So to speak.

The important thing is that we retain backwards compatibility with
current XLOG_XACT_COMMIT. I'm not worried what we call the other one.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bernd Helmle 2011-06-16 13:37:24 Re: Patch - Debug builds without optimization
Previous Message Robert Haas 2011-06-16 13:23:53 Re: use less space in xl_xact_commit patch