| From: | Aidan Van Dyk <aidan(at)highrise(dot)ca> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pgindent weirdness |
| Date: | 2011-04-20 17:03:14 |
| Message-ID: | BANLkTim7sY97Nr4qG5REjHzuxG-BQv=ovA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 20, 2011 at 12:38 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> So in the case at hand, we actually *need* to remove the "struct" from
>> RelationGetBufferForTuple's declaration, so that BulkInsertStateData
>> gets used as a typedef name in that way.
Since the general form seems to be to declare things as:
typedef struct foo { ... } foo;
Is there any reason why we see any struct foo in the sources other
than in the typedef line?
"Legacy" and "invasive patch" are good enough reasons, if they are it...
a.
--
Aidan Van Dyk Create like a god,
aidan(at)highrise(dot)ca command like a king,
http://www.highrise.ca/ work like a slave.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-04-20 17:10:05 | Re: pgindent weirdness |
| Previous Message | Greg Stark | 2011-04-20 16:52:37 | Re: Formatting Curmudgeons WAS: MMAP Buffers |