Re: Postmaster holding unlinked files for pg_largeobject table

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Kevin Grittner <kevin(dot)grittner(at)wicourts(dot)gov>, alexk <alexk(at)commandprompt(dot)com>, Alexander Shulgin <ash(at)commandprompt(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Postmaster holding unlinked files for pg_largeobject table
Date: 2011-06-09 19:03:26
Message-ID: BANLkTik3NbH3XhFP8c--uKW7+5iACQUyHw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Thu, Jun 9, 2011 at 3:02 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Thu, Jun 9, 2011 at 2:45 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> My thought is that it needs some beta testing.  Perhaps it'd be sane to
>>> push it into beta2 now, and then back-patch sometime after 9.1 final,
>>> if no problems pop up.
>
>> I think it'd be sensible to back-patch it.  I'm not sure whether now
>> or later.  It's a bug fix that is biting real users in the field, so
>> it seems like we ought to do something about it.
>
> I don't deny it's a bug fix; I'm just dubious about the risk-reward
> ratio.  As to risk: the patch isn't trivial (notice Alvaro didn't get it
> right the first time).  As to reward: it's been like that since forever,
> so if the problem were really serious, we'd have identified it before.
>
> Letting it age a bit during beta would do a lot to damp down the risk
> side of the equation.

OK by me.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Alvaro Herrera 2011-06-09 20:02:14 Re: Postmaster holding unlinked files for pg_largeobject table
Previous Message Tom Lane 2011-06-09 19:02:33 Re: Postmaster holding unlinked files for pg_largeobject table

Browse pgsql-hackers by date

  From Date Subject
Next Message Kohei KaiGai 2011-06-09 19:09:56 Re: [v9.1] sepgsql - userspace access vector cache
Previous Message Tom Lane 2011-06-09 19:02:33 Re: Postmaster holding unlinked files for pg_largeobject table