Re: Adding an example for replication configuration to pg_hba.conf

On Tue, May 24, 2011 at 10:53, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Magnus Hagander wrote:
>> On Thu, May 19, 2011 at 11:09, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> > On Thu, May 19, 2011 at 2:44 PM, Selena Deckelmann <selena(at)chesnok(dot)com> wrote:
>> >> On Wed, May 18, 2011 at 8:20 PM, Alvaro Herrera
>> >> <alvherre(at)commandprompt(dot)com> wrote:
>> >>> Excerpts from Greg Smith's message of mi? may 18 23:07:13 -0400 2011:
>> >>>> Two things that could be changed from this example to make it more useful:
>> >>>
>> >>>> -The default database is based on your user name, which is postgres in
>> >>>> most packaged builds but not if you compile your own. ?I don't know
>> >>>> whether it's practical to consider substituting that into this file, or
>> >>>> if it's just enough to mention that as an additional doc comment.
>> >>>
>> >>> You mean the default username, not the default database, but yeah; so do
>> >>> we need a @default_username@ token to be replaced by initdb with
>> >>> whatever it has as effective_user? ?(In this case the patch is no longer
>> >>> 2 lines, but still should be trivial enough).
>> >>
>> >> That would be nice. So, we just add that token to initdb? Seems simple.
>> >>
>> >> I added some explanation of the all vs replication bit in the header comments.
>> >>
>> >> Revision attached.
>> >
>> > Looks good to me.
>> >
>> > As I mentioned offlist, I'd like it in teal please.
>>
>> Applied with some further minor bikeshedding (remove trailing spaces,
>> rewrap so columns aren't wider than 80 chars, etc)
>
> Let me just point out that people who have already run initdb during
> beta will not see this in their pg_hba.conf, nor in their
> share/pg_hba.conf.sample, even after they have upgraded to a later beta,
> unless they run initdb.  However, we have bumped the catalog version for
> something else so they should then get this change.

Why would they not see it in their share/pg_hba.conf.sample?

It will not affect the existing one in $PGDATA, but why wouldn't the
installed .sample change?

> My point is if we change configuration files and then don't bump the
> catalog version, the share/*.sample files get out of sync with the files
> in /data, which can be kind of confusing.

They would - but what you are saying above is that they would not get
out of sync, because the share/*.sample also don't update. Just a
mistake in what you said above, or am I missing something?

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/