Re: Fwd: Keywords in pg_hba.conf should be field-specific

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fwd: Keywords in pg_hba.conf should be field-specific
Date: 2011-06-21 22:06:20
Message-ID: BANLkTi=fz7NSzfaXwpfhgpDFLJKUCu_i+w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2011/6/21 Alvaro Herrera <alvherre(at)commandprompt(dot)com>:
> Excerpts from Pavel Stehule's message of mar jun 21 11:04:11 -0400 2011:
>> 2011/6/21 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>
>> > AFAICS, this is only important in places where the syntax allows either
>> > a keyword or an identifier.  If only a keyword is possible, there is no
>> > value in rejecting it because it's quoted.  And, when you do the test,
>> > I think you'll find that it would be breaking hba files that used to
>> > work (though admittedly, it's doubtful that there are any such in the
>> > field).
>>
>> It should be better documented. I don't think so this is good
>> solution, but this is not too important.
>
> On the contrary -- we should support it but not document it.  I mean,
> what good would that do?  If someone is so silly to uselessly quote
> keywords, let them do it, but let's not encourage it.

it is argument too :)

It has not good solution - one break compatibility, second is strange
and undocumented :(

Actually I don't remember a issues about pg_hba.conf - probably 99%
users work with default configuration, so we can leave this file in
current state.

I am thinking so a notice in pg_hba.conf can be redesigned - almost
all people don't read it, but if someone read it, then he needs a
correct information - in sense, so on quotes works only where literal
or known literal can be entered.

Regards

Pavel Stehule

>
> --
> Álvaro Herrera <alvherre(at)commandprompt(dot)com>
> The PostgreSQL Company - Command Prompt, Inc.
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-06-21 22:38:29 Re: Fwd: Keywords in pg_hba.conf should be field-specific
Previous Message Alexey Klyukin 2011-06-21 21:50:23 Re: Identifying no-op length coercions