Re: patch: Allow \dd to show constraint comments

From: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch: Allow \dd to show constraint comments
Date: 2011-06-05 20:36:57
Message-ID: BANLkTi==A_PRgi-D_pZnVTqeHOAXHQduvg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 24, 2011 at 10:31 PM, Josh Kupershmidt <schmiddy(at)gmail(dot)com> wrote:
> Attached is a rebased patch. From a quick look, it seems that most of
> the object types missing from \dd are already covered by pg_comments
> (cast, constraint, conversion, domain, language, operator class,
> operator family). A few objects would probably still need to be added
> (foreign data wrapper, server).

Here's another update to this patch. Includes:
* rudimentary doc page for pg_comments
* 'foreign data wrapper' and 'server' comment types now included in
pg_comments; regression test updated

Still TODO:
* psql's \dd should read from pg_comments. But I think we need some
simple way to distinguish comments on system objects from non-system
objects, which we'd need for differentiating \dd from \ddS, not to
mention being useful for ad-hoc queries. I'm open to ideas here.

Josh

Attachment Content-Type Size
pg_comments.v4.patch text/x-patch 66.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-06-05 21:46:32 Re: reducing the overhead of frequent table locks - now, with WIP patch
Previous Message Dimitri Fontaine 2011-06-05 20:16:41 Re: BLOB support