| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Jan Urbański <wulczer(at)wulczer(dot)org>, Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: review: psql: edit function, show function commands patch |
| Date: | 2010-08-12 13:16:49 |
| Message-ID: | AANLkTinc-ZZicVmRmTcUUT7j8LKuxXb0ZwswvYX+3jv3@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello
attached updated \sf implementation. It is little bit simplyfied with
support a pager and output forwarding. Formating was updated per Tom's
request.
Regards
Pavel Stehule
>
> BTW, the last I looked, \sf+ was using what I thought to be a quite ugly
> and poorly-considered formatting for the line number. I would suggest
> eight blanks for a header line and "%-7d " as the prefix format for a
> numbered line. The reason for making sure the prefix is 8 columns rather
> than some other width is to not mess up tab-based formatting of the
> function body. I would also prefer a lot more visual separation between
> the line number and the code than "%4d " will offer; and as for the
> stars, they're just useless and distracting.
>
> regards, tom lane
>
| Attachment | Content-Type | Size |
|---|---|---|
| showfuncdef.diff | text/x-patch | 7.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-08-12 14:15:57 | Re: Libpq: PQftype, PQfsize |
| Previous Message | Andrew Dunstan | 2010-08-12 13:07:40 | Re: Regression tests versus the buildfarm environment |