| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Include WAL in base backup |
| Date: | 2011-01-25 15:34:54 |
| Message-ID: | AANLkTinbj4_h3MBGq8L7deB3Xpmu0JJmPWwYy0S3=q4J@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 25, 2011 at 15:04, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Tue, Jan 25, 2011 at 10:28 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>> (the discussed changse above have been applied and pushed to github)
>>
>> Thanks! I'll test and review that.
>
> WAL file might get recycled or removed while walsender is reading it.
> So the WAL file which pg_basebackup seemingly received successfully
> might be actually invalid. Shouldn't we need to check that what we read
> is valid as XLogRead does?
Yikes. Yes, you are correct. We do catch the case when it is removed,
but not when it's recycled.
I'll need to look at that. Not sure if I'll have time today, but I'll
do it as soon as I can :-)
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2011-01-25 15:41:05 | Re: SSI patch version 14 |
| Previous Message | Robert Haas | 2011-01-25 15:33:35 | Re: Re: patch: fix performance problems with repated decomprimation of varlena values in plpgsql |