| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, Andres Freund <andres(at)anarazel(dot)de>, Florian Pflug <fgp(at)phlo(dot)org>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Greg Smith <greg(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com> |
| Subject: | Re: Stefan's bug (was: max_standby_delay considered harmful) |
| Date: | 2010-05-18 08:34:04 |
| Message-ID: | AANLkTin3sc9vEjVy5fpnaas2YU1grnHgpeQ-4sSBDkWL@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 18, 2010 at 5:10 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On Tue, 2010-05-18 at 16:05 +0900, Fujii Masao wrote:
>> >>> >> ISTM that we can use XLogCtl->SharedRecoveryInProgress for that.
>> >>> >> Is this OK?
>> >>> >
>> >>> > That can change state at any time. Would that work?
>> >>>
>> >>> Yes. XLogCtl->SharedRecoveryInProgress is set to TRUE only when
>> >>> XLogCtl structure is initialized (i.e., XLOGShmemInit), and it's
>> >>> set to FALSE only at the end of recovery.
>> >>
>> >> You should be using RecoveryInProgress()
>> >
>> > Isn't access to a bool variable atomic?
>>
>> If it's not atomic, I'll add the following comment into CancelBackup():
>>
>> Don't bother with lock to access XLogCtl->SharedRecoveryInProgress,
>> because there should be no other processes running when this code
>> is reached.
>
> Call it via a function. There is no need for postmaster to know the
> innards of xlog.c, which could change in future. Modularity.
In the patch, it's accessed in CancelBackup() which is in xlog.c.
CancelBackup() should call further wrapping function?
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2010-05-18 08:59:59 | Re: Clarifications of licences on pgfoundry |
| Previous Message | Dave Page | 2010-05-18 08:33:48 | Re: Clarifications of licences on pgfoundry |