From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: OCLASS_FOREIGN_TABLE support is incomplete |
Date: | 2011-02-05 06:34:17 |
Message-ID: | AANLkTimrQ8pGvb3u80yyWqfe3ixSRn46mbeYP_gca69j@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Feb 4, 2011 at 2:46 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Feb 4, 2011 at 2:44 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> While poking at the extensions patch I noticed that doDeletion() and
>> getObjectDescription() both seem to be missing cases for
>> OCLASS_FOREIGN_TABLE. Surely this is broken.
>
> I'll look into fixing this.
Err... wait. Actually, I think the right thing to do might be to
remove OCLASS_FOREIGN_TABLE altogether. I don't think it's actually
used for anything. For a foreign table, we use OCLASS_CLASS, just as
we do for indexes and sequences. I think that's just leftover crap
that I failed to rip out.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2011-02-05 06:37:49 | Re: [HACKERS] Slow count(*) again... |
Previous Message | Robert Haas | 2011-02-05 06:29:35 | Re: ALTER TYPE 2: skip already-provable no-work rewrites |