From: | Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Greg Smith <greg(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: We need to log aborted autovacuums |
Date: | 2011-02-05 17:54:28 |
Message-ID: | AANLkTimo7HHYA2yy+ATBJFH8ZzSLL24T_PiZ6sZ_jBA2@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2011/2/4 Robert Haas <robertmhaas(at)gmail(dot)com>:
> On Sun, Jan 30, 2011 at 10:26 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Sun, Jan 30, 2011 at 10:03 PM, Alvaro Herrera
>> <alvherre(at)commandprompt(dot)com> wrote:
>>> Excerpts from Robert Haas's message of dom ene 30 23:37:51 -0300 2011:
>>>
>>>> Unless I'm missing something, making autovacuum.c call
>>>> ConditionalLockRelationOid() is not going to work, because the vacuum
>>>> transaction isn't started until we get all the way down to
>>>> vacuum_rel().
>>>
>>> Maybe we need ConditionalLockRelationOidForSession or something like
>>> that?
>>
>> That'd be another way to go, if there are objections to what I've
>> implemented here.
>
> Seeing as how there seem to be neither objections nor endorsements,
> I'm inclined to commit what I proposed
what do you implement exactly ?
* The original request from Josh to get LOG when autovac can not run
because of locks
* VACOPT_NOWAIT, what is it ?
>more or less as-is. There
> remains the issue of what do about the log spam. Josh Berkus
> suggested logging it when log_autovacuum_min_duration != -1, which
> seems like a bit of an abuse of that setting, but it's certainly not
> worth adding another setting for, and the alternative of logging it
> at, say, DEBUG2 seems unappealing because you'll then have to turn on
> logging for a lot of unrelated crap to get this information. So on
> balance I think that proposal is perhaps the least of evils.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
--
Cédric Villemain 2ndQuadrant
http://2ndQuadrant.fr/ PostgreSQL : Expertise, Formation et Support
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2011-02-05 17:58:13 | Re: SSI patch version 14 |
Previous Message | Tom Lane | 2011-02-05 15:56:58 | Re: OCLASS_FOREIGN_TABLE support is incomplete |