Re: pg_dump directory archive format / parallel pg_dump

From: Jaime Casanova <jaime(at)2ndquadrant(dot)com>
To: Joachim Wieland <joe(at)mcknight(dot)de>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump directory archive format / parallel pg_dump
Date: 2011-02-07 06:51:56
Message-ID: AANLkTimF9jrAcyK42ALSAKk8y3EYP1VX5jk8o02vc0rQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Feb 6, 2011 at 2:12 PM, Jaime Casanova <jaime(at)2ndquadrant(dot)com> wrote:
> On Tue, Feb 1, 2011 at 11:32 PM, Joachim Wieland <joe(at)mcknight(dot)de> wrote:
>> On Sun, Jan 30, 2011 at 5:26 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> The parallel pg_dump portion of this patch (i.e. the still-uncommitted
>>> part) no longer applies.  Please rebase.
>>
>> Here is a rebased version with some minor changes as well. I haven't
>> tested it on Windows now but will do so as soon as the Unix part has
>> been reviewed.
>>
>
> code review:
>

ah! two other things i forget:

- there is no docs
- pg_dump and pg_restore are inconsistent:
pg_dump requires the directory to be provided with the -f option:
pg_dump -Fd -f dir_dump
pg_restore pass the directory as an argument for -Fd: pg_restore -Fd dir_dump

--
Jaime Casanova         www.2ndQuadrant.com
Professional PostgreSQL: Soporte y capacitación de PostgreSQL

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Shigeru HANADA 2011-02-07 07:00:37 Re: review: FDW API
Previous Message Itagaki Takahiro 2011-02-07 06:39:39 Re: SQL/MED - file_fdw