| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Greg Smith <greg(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: auto-sizing wal_buffers |
| Date: | 2011-01-23 02:52:18 |
| Message-ID: | AANLkTimAzopJD5wHu354p47fN3AepoFvCoCG8=RF7-1+@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 22, 2011 at 9:42 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> Oh, you're complaining about SetConfigOption, not the assign hooks.
>
>> I was actually complaining about the latter, and then switched gears
>> to the former. I'm an equal-opportunity complainer today, I guess...
>
> It does strike me that we could provide SetConfigOptionInt,
> SetConfigOptionBool, and SetConfigOptionReal for the benefit of callers
> who'd prefer to pass values in those formats. They'd still do sprintf
> internally, but this would make the call sites a bit cleaner.
Why do we need to double the conversion in the first place?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-01-23 02:55:55 | Re: Bug in pg_describe_object, patch v2 |
| Previous Message | Tom Lane | 2011-01-23 02:50:47 | Re: Bug in pg_describe_object, patch v2 |