Re: patch (for 9.1) string functions

On Sun, Jul 11, 2010 at 10:30 PM, Itagaki Takahiro
<itagaki(dot)takahiro(at)gmail(dot)com> wrote:
> 2010/7/9 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
>> I am sending a actualised patch
>> * removed concat_json
>> * renamed function rvsr to reverse
>> * functions format, sprintf and concat* are stable now (as to_char for example)
>
> I'd like to move all proposed functions into the core, and not to add
> contrib/stringfunc.
> I think those functions are very useful and worth adding in core.
> * concat(), concat_ws(), reverse(), left() and right() are ready to commit.
> * format() is almost ready, except consensus of NULL representation.
> * sprintf() is also useful, but we cannot use swprintf() in it because
>  there are many problems in converting to wide chars. We should
>  develop mbchar-aware version of %s formatter.
> * IMHO, concat_sql() has very limited use cases. Boolean  and numeric
>  values are not quoted, but still need product-specific conversions because
>  some DBs prefer 1/0 instead of true/false.
>  Also, dblink_build_sql_insert() provides similar functionality. Will
> we have both?

I'm all in favor of putting such things in core as are supported by
multiple competing products, but is that really true for all of these?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company