| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Leonardo Francalanci <m_lists(at)yahoo(dot)it>, Josh Kupershmidt <schmiddy(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: I: About "Our CLUSTER implementation is pessimal" patch |
| Date: | 2010-10-08 05:47:57 |
| Message-ID: | AANLkTikxc-x3Zz+e4i_ufutbG+Z8nD_1Qa6+BJ5uqrQP@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 8, 2010 at 10:49 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> writes:
>> I wrote a patch to improve CLUSTER VERBOSE (and VACUUM FULL VERBOSE).
>> The patch should be applied after sorted_cluster-20100721.patch .
>
> Applied with minor fixes; in particular, I think you got the effects of
> rewrite_heap_dead_tuple backwards. When a tuple is removed from
> unresolved_tups, that amounts to changing its status from "recently
> dead" to "dead and will not be written out".
Ah, yes. I misunderstood the behavior. Thanks for the fix!
--
Itagaki Takahiro
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2010-10-08 05:48:18 | Re: standby registration (was: is sync rep stalled?) |
| Previous Message | Heikki Linnakangas | 2010-10-08 05:43:40 | Re: standby registration (was: is sync rep stalled?) |