| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
| Cc: | Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: SQL/MED - file_fdw |
| Date: | 2010-12-16 14:09:55 |
| Message-ID: | AANLkTiku7nyR+sNuAB3Ys0AVyKYfn9+maC6_2=scqnF7@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 16, 2010 at 5:35 AM, Itagaki Takahiro
<itagaki(dot)takahiro(at)gmail(dot)com> wrote:
> Ah, I found my bug in BeginCopy(), but it's in the usage of
> ExecCheckRTPerms() rather than RowExclusiveLock, right?
> The target relation should have been opened and locked by the caller.
> I think we can move the check to DoCopy() as like as checking for
> superuser(). In my understanding, we don't have to check permissions
> in each FDW because it was done in parse and analyze phases.
> Could you fix it? Or, shall I do?
I believe that our project policy is that permissions checks must be
done at execution time, not parse/plan time.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2010-12-16 14:11:01 | Re: mvcc & DML on the same row |
| Previous Message | Robert Haas | 2010-12-16 14:08:39 | Re: Extensions, patch v18 (merge against master, bitrot-only-fixes) |