| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
|---|---|
| To: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_execute_from_file, patch v10 |
| Date: | 2010-12-14 23:59:42 |
| Message-ID: | AANLkTikqKPvxkY6mhk=PbwHAvxi7vUjh4h7FnwyuoTc0@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 15, 2010 at 04:39, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> wrote:
> Well, in fact, the extension's code is using either execute_sql_file()
> or read_text_file_with_endoding() then @extschema@ replacement then
> execute_sql_string(), all those functions called directly thanks to
> #include "utils/genfile.h". No DirectFunctionCall'ing, we can easily
> remove SQL callable forms.
>
> So what we need is 2, 3 and 4 (because 4 builds on 2).
No, 3 is not needed. You can use SPI_exec() directly instead of
exporting execute_sql_string().
--
Itagaki Takahiro
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Koichi Suzuki | 2010-12-15 00:06:40 | Re: WIP patch for parallel pg_dump |
| Previous Message | Jan Urbański | 2010-12-14 23:19:53 | Re: hstores in pl/python |