| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | match_clause_to_indexcol() |
| Date: | 2010-11-20 17:45:06 |
| Message-ID: | AANLkTi=N5HmUgWox3JJerxT-cwZtgwcu4dbHiVdF-LrA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I was looking at KNNGIST some more today and found myself trying to
disentangle what match_clause_to_indexcol() is actually doing. It
appears to me that the opfamily passed to that function is always the
same as index->opfamily[indexcol], which seems like needless
notational complexity. Maybe I'm missing something, but the attached
patch seems to make things simpler and clearer. Thoughts?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| simplify_match_clause_to_indexcol_api.patch | text/x-patch | 2.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-11-20 18:01:50 | Re: match_clause_to_indexcol() |
| Previous Message | Tom Lane | 2010-11-20 17:34:04 | Re: [PATCH] Custom code int(32|64) => text conversions out of performance reasons |