From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
---|---|
To: | Quan Zongliang <quanzongliang(at)gmail(dot)com> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, David Fetter <david(at)fetter(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Fw: patch for pg_ctl.c to add windows service start-type |
Date: | 2010-09-30 02:40:10 |
Message-ID: | AANLkTi=4Ck+jWeEQ++f5yNyGBmypnivwNqV=JOC8DF_p@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi, I have a question about the latest patch.
On Sun, Aug 22, 2010 at 11:03 PM, Quan Zongliang
<quanzongliang(at)gmail(dot)com> wrote:
> New patch attached. How about this?
>> I don't see us ever using anything other than auto or demand. The
>> others aren't for "regular services"
+ set_starttype(char *starttypeopt)
+ {
+ if (strcmp(starttypeopt, "a") == 0 || strcmp(starttypeopt, "auto") == 0)
+ pgctl_start_type = SERVICE_AUTO_START;
+ else if (strcmp(starttypeopt, "d") == 0 || strcmp(starttypeopt,
"demand") == 0)
+ pgctl_start_type = SERVICE_DEMAND_START;
It accepts only "a" and "auto" for auto, but "au" or "aut" are rejected.
Is is an intended behavior? I think we can use prefix match here because
we use the logic in some places. For example,
postgres=# SELECT 'tru'::bool, 'fal'::bool;
bool | bool
------+------
t | f
(1 row)
--
Itagaki Takahiro
From | Date | Subject | |
---|---|---|---|
Next Message | Josh Kupershmidt | 2010-09-30 02:41:01 | Re: I: About "Our CLUSTER implementation is pessimal" patch |
Previous Message | Robert Haas | 2010-09-30 02:30:19 | Re: Path question |