Re: Add support for logging the current role

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add support for logging the current role
Date: 2011-01-12 15:06:13
Message-ID: AANLkTi=+D+oH-a5dq0fdSfBoFyvd1PkycgGmm1_MD_SP@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 12, 2011 at 9:23 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> Minor enhancement, but a valuable one imv.  Hopefully there aren't any
> issues with it. :)

1. Why %o? That's not obviously mnemonic. Perhaps %U?

2. It won't be clear to people reading this what the difference is
between %u and this. You probably need to reword the documentation
for the existing option as well as documenting the new one.

3. Please attach the patch rather than including it inline, if possible.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2011-01-12 15:12:23 Re: Add support for logging the current role
Previous Message Ron Mayer 2011-01-12 14:52:54 Re: Compatibility GUC for serializable