Re: dblink performance regression

> On 2013/12/08, at 10:50, Joe Conway <mail(at)joeconway(dot)com> wrote:
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>> On 12/07/2013 05:41 PM, Fabrízio de Royes Mello wrote:
>>
>> On Sat, Dec 7, 2013 at 11:20 PM, Michael Paquier
>> <michael(dot)paquier(at)gmail(dot)com <mailto:michael(dot)paquier(at)gmail(dot)com>>
>> wrote:
>>>>
>>>> IMHO is more elegant create a procedure to encapsulate the code
>>>> to avoid redundancy.
>>> Yep, perhaps something like PQsetClientEncodingIfDifferent or
>>> similar would make sense.
>>
>> Well I think at this first moment we can just create a procedure
>> inside the dblink contrib and not touch in libpq.
>
> Maybe a libpq function could be done for 9.4, but not for back branches.
Agreed as this would change the spec of libpq between minor releases. Sorry for not being clear myself.

> -- we're only talking about two lines of added redundancy which is
> less lines of code than a new function would add. But if we create
> PQsetClientEncodingIfDifferent() (or whatever) we can remove those
> extra lines in 9.4 ;-)

--
Michael
(Sent from my mobile phone)