Re: pg_receivexlog add synchronous mode

From: <furuyao(at)pm(dot)nttdata(dot)co(dot)jp>
To: <masao(dot)fujii(at)gmail(dot)com>
Cc: <andres(at)2ndquadrant(dot)com>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_receivexlog add synchronous mode
Date: 2014-06-30 10:09:43
Message-ID: A9C510524E235E44AE909CD4027AE196BAAA06D800@MBX-MSG-SV03.msg.nttdata.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Thanks for the review!
>
> + if (secs <= 0)
> + secs = 1; /* Always sleep at least 1 sec */
> +
> + sleeptime = secs * 1000 + usecs / 1000;
>
> The above is the code which caused that problem. 'usecs' should have been
> reset to zero when 'secs' are rounded up to 1 second. But not. Attached
> is the updated version of the patch.
Thank you for the refactoring v2 patch.
I did a review of the patch.

1. applied cleanly and compilation was without warnings and errors
2. all regress tests was passed ok
3. sleeptime is ok when the --status-intarvall is set to 1

Regards,

--
Furuya Osamu

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Abhijit Menon-Sen 2014-06-30 10:38:56 Re: Autonomous Transaction (WIP)
Previous Message Asif Naeem 2014-06-30 10:05:11 Re: Extending MSVC scripts to support --with-extra-version