| From: | <furuyao(at)pm(dot)nttdata(dot)co(dot)jp> |
|---|---|
| To: | <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | <andres(at)2ndquadrant(dot)com>, <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_receivexlog add synchronous mode |
| Date: | 2014-06-26 10:01:45 |
| Message-ID: | A9C510524E235E44AE909CD4027AE196BAAA06D7FB@MBX-MSG-SV03.msg.nttdata.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> The patch looks somewhat complicated and bugs can be easily introduced
> because it tries to not only add new feature but also reorganize the main
> loop in HandleCopyStream at the same time. To keep the patch simple, I'm
> thinking to firstly apply the attached patch which just refactors the
> main loop. Then we can apply the main patch, i.e., add new feature.
> Thought?
Thank you for the refactoring patch.
I did a review of the patch.
As a result, I found the calculation of sleeptime when the --status-intarvall is set to 1 was incorrect.
--status-intarvall 1 --> sleeptime 1.9999 !?
--status-intarvall 2 --> sleeptime 1.9999 OK
--status-intarvall 3 --> sleeptime 2.9999 OK
Regards,
--
Furuya Osamu
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-06-26 10:20:06 | Re: better atomics - v0.5 |
| Previous Message | Simon Riggs | 2014-06-26 10:00:26 | Re: Allowing NOT IN to use ANTI joins |