Re: Bug in walsender when calling out to do_pg_stop_backup (and others?)

From: Greg Jaskiewicz <gj(at)pointblue(dot)com(dot)pl>
To: Florian Pflug <fgp(at)phlo(dot)org>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug in walsender when calling out to do_pg_stop_backup (and others?)
Date: 2011-10-19 15:47:14
Message-ID: A3D26723-F4A9-40AA-8E6A-F630B208BEF8@pointblue.com.pl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 15 Oct 2011, at 11:31, Florian Pflug wrote:
>
> Ok, here's a first cut.

So I looked at the patch, and first thing that pops out,
is lack of the volatile keyword before the ClientConnectionLostPending variable is defined. Is that done on purpose ? Is that on purpose ?

Otherwise the patch itself looks ok.
I haven't tested the code, just reviewed the patch itself. And it obviously needs testing, should be easy to follow your original problem description.

Btw, I just tried to do it through commitfest.postgresql.org , but before I get my head around on how to add myself to the reviewer list there - I thought I'll just send this response here.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Florian Pflug 2011-10-19 15:54:22 Re: Bug in walsender when calling out to do_pg_stop_backup (and others?)
Previous Message Greg Stark 2011-10-19 15:30:57 Re: new compiler warnings