Re: [v9.5] Custom Plan API

> > I'd like to follow this direction, and start stripping the DDL support.
>
> ...please make it so.
>
The attached patch eliminates DDL support.

Instead of the new CREATE CUSTOM PLAN PROVIDER statement,
it adds an internal function; register_custom_scan_provider
that takes custom plan provider name and callback function
to add alternative scan path (should have a form of CustomPath)
during the query planner is finding out the cheapest path to
scan the target relation.
Also, documentation stuff is revised according to the latest
design.
Any other stuff keeps the previous design.

Thanks,
--
NEC OSS Promotion Center / PG-Strom Project
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>

> -----Original Message-----
> From: pgsql-hackers-owner(at)postgresql(dot)org
> [mailto:pgsql-hackers-owner(at)postgresql(dot)org] On Behalf Of Robert Haas
> Sent: Tuesday, August 26, 2014 1:09 PM
> To: Kohei KaiGai
> Cc: Tom Lane; Alvaro Herrera; Kaigai Kouhei(海外 浩平); Shigeru Hanada;
> Simon Riggs; Stephen Frost; Andres Freund; PgHacker; Jim Mlodgenski; Peter
> Eisentraut
> Subject: Re: [HACKERS] [v9.5] Custom Plan API
>
> On Fri, Aug 22, 2014 at 9:48 PM, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
> > One thing I was pointed out, it is the reason why I implemented DDL
> > support, is that intermediation of c-language function also loads the
> > extension module implicitly. It is an advantage, but not sure whether
> > it shall be supported from the beginning.
>
> That is definitely an advantage of the DDL-based approach, but I think it's
> too much extra machinery for not enough real advantage. Sounds like we
> all agree, so ...
>
> > I'd like to follow this direction, and start stripping the DDL support.
>
> ...please make it so.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL
> Company
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers