From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Joachim Wieland <joe(at)mcknight(dot)de>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
Subject: | Re: patch for parallel pg_dump |
Date: | 2012-04-03 16:37:43 |
Message-ID: | 9632.1333471063@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Tue, Apr 3, 2012 at 12:17 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> No, the reason for write_stderr() is that fprintf(stderr) is unreliable
>> on Windows. If memory serves, it can actually crash in some situations.
> Dude, we're already doing fprintf(stderr) all over pg_dump. If it's
> unreliable even in front-end code, we're screwed anyway. That is a
> non-objection.
No, it isn't. The fact that it works in pg_dump doesn't extrapolate
to other places. (In particular, it will absolutely not work in libpq,
at least not in all the environments where libpq is supposed to work.)
I think what we've got at the moment is something that's adequate for
pg_dump, and that's all that it is. Concluding that it can be used in
all frontend code is way premature, and therefore I'm -1 on the idea
of exposing it in non-pg_dump header files.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2012-04-03 17:20:44 | Re: patch for parallel pg_dump |
Previous Message | Robert Haas | 2012-04-03 16:28:01 | Re: patch for parallel pg_dump |