Re: [HACKERS] [PATCHES] Patch to log usage of temporary files

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Guillaume Smet" <guillaume(dot)smet(at)gmail(dot)com>
Cc: "Bruce Momjian" <bruce(at)momjian(dot)us>, "Bill Moran" <wmoran(at)collaborativefusion(dot)com>, pgsql-patches(at)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCHES] Patch to log usage of temporary files
Date: 2007-01-12 19:59:20
Message-ID: 9537.1168631960@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Guillaume Smet" <guillaume(dot)smet(at)gmail(dot)com> writes:
> On 1/12/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> (2) there is already a generalized solution to this, it's called
>> log_min_error_statement.

> I didn't think of that when posting my message but Bruce seems to say
> that we can't use it in this case.

Dunno why he thinks that. But there is a point here that could use
improvement: shouldn't log_min_error_statement be measured on the same
scale as log_min_messages, ie, LOG is relatively high priority rather
than relatively low priority? As the code stands, you'd have to knock
it down to DEBUG1 in order to see the statement generating a LOG
message. This might be harmless (since messages below log_min_messages
won't generate log output at all), but it's surely a bit confusing.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-01-12 20:04:46 Re: [PATCHES] Patch to log usage of temporary
Previous Message Simon Riggs 2007-01-12 19:50:54 Re: [HACKERS] table partioning performance

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-01-12 20:04:46 Re: [PATCHES] Patch to log usage of temporary
Previous Message Guillaume Smet 2007-01-12 19:48:17 Re: [HACKERS] [PATCHES] Patch to log usage of temporary files