From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Deferring some AtStart* allocations? |
Date: | 2014-06-30 01:12:49 |
Message-ID: | 9226.1404090769@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-06-29 19:52:23 -0400, Tom Lane wrote:
>> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
>>> Why aren't we delaying allocations in e.g. AtStart_Inval(),
>>> AfterTriggerBeginXact() to when the data structures are acutally used?
>>
>> Aren't we? Neither of those would be doing much work certainly.
> They are perhaps not doing much in absolute terms, but it's a fair share
> of the processing overhead for simple statements. AfterTriggerBeginXact()
> is called unconditionally from StartTransaction() and does three
> MemoryContextAlloc()s. AtStart_Inval() one.
> I think they should just be initialized whenever the memory is used?
> Doesn't look too complicated to me.
Meh. Even "SELECT 1" is going to be doing *far* more pallocs than that to
get through raw parsing, parse analysis, planning, and execution startup.
If you can find a few hundred pallocs we can avoid in trivial queries,
it would get interesting; but I'll be astonished if saving 4 is measurable.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2014-06-30 01:19:44 | Re: idle_in_transaction_timeout |
Previous Message | Andres Freund | 2014-06-30 00:19:31 | Re: Deferring some AtStart* allocations? |