Should we get rid of custom_variable_classes altogether?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Should we get rid of custom_variable_classes altogether?
Date: 2011-10-02 21:05:38
Message-ID: 922.1317589538@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

During the discussion of Alexey Klyukin's rewrite of ParseConfigFile,
considerable unhappiness was expressed by various people about the
complexity and relative uselessness of the custom_variable_classes GUC.
While working over his patch just now, I've come around to the side that
was saying that this variable isn't worth its keep. We don't have any
way to validate whether the second part of a qualified GUC name is
correct, if its associated extension module isn't loaded, so how much
point is there in validating the first part? And the variable is
certainly a pain in the rear both to DBAs and to the GUC code itself.

So at this point I'd vote for just dropping it and always allowing
custom (that is, qualified) GUC names to be set, whether the prefix
corresponds to any loaded module or not.

Comments, other proposals?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Abbate 2011-10-02 21:15:53 Re: pg_dump issues
Previous Message Tom Lane 2011-10-02 20:57:54 Re: REVIEW proposal: a validator for configuration files