Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

On 17 November 2013 12:25 Amit Kapila wrote:
> On Sat, Nov 16, 2013 at 4:35 PM, Haribabu kommi
> <haribabu(dot)kommi(at)huawei(dot)com> wrote:
> > On 16 November 2013 09:43 Amit Kapila wrote:
> >> On Fri, Nov 15, 2013 at 10:18 PM, Peter Eisentraut <peter_e(at)gmx(dot)net>
> >> wrote:
> >> > On 11/14/13, 2:50 AM, Amit Kapila wrote:
> >> >> Find the rebased version attached with this mail.
> >> >
> > ereport(ERROR,
> >
> (errcode(ERRCODE_CONFIG_FILE_ERROR),
> > errmsg("configuration file
> \"%s\" contains errors",
> > -
> ConfigFileName)));
> > +
> > + ErrorConfFile)));
> >
> > The ErrorConfFile prints "postgresql.auto.conf" only if there is any
> > parsing problem with postgresql.auto.conf otherwise it always print
> "postgresql.conf" because of any other error.
>
> Changed to ensure ErrorConfFile contains proper config file name.
> Note: I have not asssigned file name incase of error in below loop,
> as file name in gconf is NULL in most cases and moreover this loops
> over
> guc_variables which doesn't contain values/parameters from
> auto.conf. So I don't think it is required to assign ErrorConfFile in
> this loop.
>
> ProcessConfigFile(GucContext context)
> {
> ..
> for (i = 0; i < num_guc_variables; i++)
> {
> struct config_generic *gconf = guc_variables[i];
>
> ..
> }

Code changes are fine.
If two or three errors are present in the configuration file, it prints the last error
Configuration parameter file only. Is it required to be mentioned in the documentation?

> >
> > if any postmaster setting which are set by the alter system command
> > which leads to failure of server start, what is the solution to user
> > to proceed further to start the server. As it is mentioned that the
> > auto.conf file shouldn't be edited manually.
>
> Yeah, but in case of emergency user can change it to get server started.
> Now the question is whether to mention it in documentation, I think we
> can leave this decision to committer. If he thinks that it is better to
> document then I will update it.

Ok fine.

Regards,
Hari babu.