Re: pgsql: Revive line type

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Revive line type
Date: 2014-05-05 17:24:15
Message-ID: 8867.1399310655@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2013-10-10 02:43:20 +0000, Peter Eisentraut wrote:
>> Revive line type

> That commit missed to update pg_type.h to the changed length of the line
> type. Patch attached.

Ouch. Good thing we caught this now.

In principle, fixing this breaks pg_upgrade'ability for anyone who was
using the line type before (presumably by compiling with
-DENABLE_LINE_TYPE). However, we're breaking things for them anyway by
changing the text representation, so that's probably not worth worrying
over.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2014-05-05 17:27:40 Re: pgsql: Revive line type
Previous Message Bruce Momjian 2014-05-05 16:38:15 pgsql: Add SGML markup tags to 9.4 release notes

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-05-05 17:25:06 Re: New and interesting replication issues with 9.2.8 sync rep
Previous Message Andres Freund 2014-05-05 17:22:47 Re: Cluster name in ps output