Re: [PATCH] add ssl_protocols configuration option

From: Alex Shulgin <ash(at)commandprompt(dot)com>
To: Dag-Erling Smørgrav <des(at)des(dot)no>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] add ssl_protocols configuration option
Date: 2014-11-27 11:51:46
Message-ID: 87zjbc6eul.fsf@commandprompt.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Dag-Erling Smørgrav <des(at)des(dot)no> writes:

> Alex Shulgin <ash(at)commandprompt(dot)com> writes:
>> OK, looks like I've come up with something workable: I've added
>> sslprotocol connection string keyword similar to pre-existing
>> sslcompression, etc. Please see attached v2 of the original patch.
>> I'm having doubts about the name of openssl.h header though,
>> libpq-openssl.h?
>
> Perhaps ssloptions.[ch], unless you plan to add non-option-related code
> there later?

I don't think anything else than common options-related code fits in
there, so ssloptions.c makes sense to me.

> BTW, there is no Regent code in your openssl.c, so the copyright
> statement is incorrect.

Good catch, I just blindly copied that from some other file.

--
Alex

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mats Erik Andersson 2014-11-27 12:28:38 initdb: Improve error recovery.
Previous Message Simon Riggs 2014-11-27 11:48:01 Re: [v9.5] Custom Plan API