Re: Formatting Curmudgeons WAS: MMAP Buffers

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Greg Smith <greg(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Formatting Curmudgeons WAS: MMAP Buffers
Date: 2011-05-10 13:41:42
Message-ID: 87oc3abrl5.fsf@hi-media-techno.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
>> Anyway, I think the intro message should be "Don't submit a big patch to
>> PostgreSQL until you've done a small patch and some patch review"
>> instead though.
>
> Well, my first patch was two-phase commit. And I had never even used
> PostgreSQL before I dived into the source tree and started to work on
> that. I did, however, lurk on the pgsql-hackers mailing list for a few
> months before posting, so I knew the social dynamics. I basically did
> exactly what Robert described elsewhere in this thread, and successfully
> avoided the culture shock.

I tend to share the experience, my first patch (not counting
documentation patch) has been extensions. The fact that everybody here
knew me before (from side projects, events, reviews in commit fests,
design reviews on list…) certainly helped, but the real deal has been
that the design was agreed on by everybody before I started — that took
*lots of* time, but really paid off (good ideas all around, real buy in,
some good beers shared, etc).

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2011-05-10 13:45:28 Re: crash-safe visibility map, take five
Previous Message Robert Haas 2011-05-10 13:22:31 Re: the big picture for index-only scans