| From: | Gregory Stark <stark(at)enterprisedb(dot)com> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Peter Eisentraut" <peter_e(at)gmx(dot)net>, <pgsql-patches(at)postgresql(dot)org>, "Joachim Wieland" <joe(at)mcknight(dot)de> |
| Subject: | Re: guc patch: Make variables fall back to default values |
| Date: | 2007-03-13 08:22:17 |
| Message-ID: | 871wjtpn7q.fsf@stark.xeocode.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> It's a release-note item ... assuming that it doesn't get reverted in
> the near future. Could we have some attention to the all-red buildfarm?
It's not just a bug. There's code missing.
The code seems to assume that all custom variables are strings. There are
about half a dozen Assert(variable->vartype == PGC_STRING) throughout the
patch. That's not true, plperl's use_strict is a boolean and we have
DefineCustome*Variable functions for each type of variable. Perl bombs because
plperl.use_strict is a boolean.
--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2007-03-13 09:06:40 | Re: pgbench on mingw needs fflush |
| Previous Message | ITAGAKI Takahiro | 2007-03-13 08:09:15 | Re: pgbench on mingw needs fflush |