Re: [9.3 bug fix] backends emit hundreds of messages when statistics file is inaccessible

From: "MauMau" <maumau307(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [9.3 bug fix] backends emit hundreds of messages when statistics file is inaccessible
Date: 2013-07-08 21:22:11
Message-ID: 843E3533897C408ABB614B6D55A13910@maumau
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

From: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> "MauMau" <maumau307(at)gmail(dot)com> writes:
>> If the directory specified by stats_temp_directory becomes inaccessible
>> to
>> postgres, enormous amount of WARNING messages are output.
>
> Well, yeah, because all of that functionality just broke. Not warning
> about it doesn't seem like a good idea. AFAICT, your patch would result
> in the situation not being remarked on anywhere except in the postmaster
> log.

No, my patch makes backend_read_statsfile_timestamp() emit just one warning
message instead of outputing the same message 1,000 times in one call. So
your concern does not exist. Is this OK?

Regards
MauMau

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2013-07-08 21:58:56 Re: Performance Improvement by reducing WAL for Update Operation
Previous Message Mike Blackwell 2013-07-08 21:21:43 Re: Performance Improvement by reducing WAL for Update Operation