| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: WAL format changes |
| Date: | 2012-06-26 01:51:45 |
| Message-ID: | 8405.1340675505@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> So I think we should change pg_resetxlog -l option to take a WAL file
> name as argument, and fix pg_upgrade accordingly.
Seems reasonable I guess. It's really specifying a starting WAL
location, but only to file granularity, so treating the argument as a
file name is sort of a type cheat but seems convenient.
If we do it that way, we'd better validate that the argument is a legal
WAL file name, so as to catch any cases where somebody tries to do it
old-style.
BTW, does pg_resetxlog's logic for setting the default -l value (from
scanning pg_xlog to find the largest existing file name) still work?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Satoshi Nagayasu | 2012-06-26 02:58:24 | Re: pg_stat_lwlocks view - lwlocks statistics |
| Previous Message | Tom Lane | 2012-06-26 01:41:59 | Re: pg_dump and dependencies and --section ... it's a mess |