| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: "unexpected EOF" messages |
| Date: | 2012-05-07 17:28:40 |
| Message-ID: | 8394.1336411720@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Mon, May 7, 2012 at 7:18 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Since the following hunk is repeated 3x, maybe it should be stuffed
>> into a function that is then called in three places:
> I considered it trivial enough not to do that for it. I can perhaps be
> convinced otherwise, but I doubt it's worth it..
I had considered suggesting the same, but decided not to on the grounds
that if we fold these into a subroutine, it will no longer be possible
to tell from the file-and-line-number info which call site reported the
error. I'm not sure that there would be cases where we'd want to tell
that, but I'm not sure there wouldn't be, either. So on the whole I
agree with the way Magnus coded it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Boszormenyi Zoltan | 2012-05-07 17:54:05 | Re: [PATCH] lock_timeout and common SIGALRM framework |
| Previous Message | Robert Haas | 2012-05-07 17:22:35 | Re: Uppercase tab completion keywords in psql? |