From: | "David E(dot) Wheeler" <david(at)kineticode(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Joshua Tolley <eggyknap(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pg_execute_from_file review |
Date: | 2010-12-06 18:03:38 |
Message-ID: | 7D60FC94-64F3-4897-880F-A361D4DC59F9@kineticode.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Dec 6, 2010, at 7:19 AM, Tom Lane wrote:
> On the whole I'd prefer not to have any substitution functionality
> hard-wired into pg_execute_file either, though I can see the argument
> that it's necessary for practical use. Basically I'm concerned that
> replace-equivalent behavior is not going to be satisfactory over the
> long run: I think eventually we're going to need to think about
> quoting/escaping behavior. So I think it's a bad idea to expose the
> assumption that it'll be done that way at the SQL level.
+1
I suspect that, for the purposes of the extensions patch, if CREATE EXTENSION could be modified to handle setting the schema itself, without requiring that the file have this magic line:
SET search_path = @extschema@;
Then there would be no need for substitutions at all.
Best,
David
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-12-06 18:05:22 | Re: profiling connection overhead |
Previous Message | David E. Wheeler | 2010-12-06 18:01:15 | Re: Per-column collation |