Re: pg_filedump 9.3: checksums (and a few other fixes)

Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> On Mon, 2013-06-24 at 20:34 -0400, Josh Kupershmidt wrote:
>> This patch is in the current CommitFest, does it still need to be
>> reviewed? If so, I notice that the version in pgfoundry's CVS is
>> rather different than the version the patch seems to have been built
>> against (presumably the pg_filedump-9.2.0.tar.gz release), and
>> conflicts in several places with cvs tip.

> Rebased against CVS tip; attached.

Thanks. I'm feeling pretty overworked these days but will try to push
this into pgfoundry in a timely fashion.

> Eventually, it would be nice to have a more full-featured offline
> checker utility. Do we want to try to turn this utility into that, or
> make a new one?

TBH, I've always been annoyed that pg_filedump is GPL and so there's no
way for us to just ship it in contrib. (That stems from Red Hat
corporate policy of a dozen years ago, but the conflict is real anyway.)
If somebody is sufficiently excited about this topic to do something
that's largely new anyway, I'd be in favor of starting from scratch so
it could be put under the usual Postgres license.

regards, tom lane