Re: pltcl broken on tcl8.5 ?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pltcl broken on tcl8.5 ?
Date: 2008-06-16 20:44:52
Message-ID: 7596.1213649092@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Buildfarm bobcat is broken running the pltcl regression tests - see
> http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=bobcat&dt=2008-06-15%2022:43:01

> and I have reproduced this on Fedora 9 myself. This distro has Tcl 8.5.1.

Hoo, nasty. Tcl_GetVar() is resetting interp->result. Not sure why
we didn't see this before ... maybe it didn't use to? Anyway, the
order of execution in

ereport(ERROR,
(errmsg("%s", interp->result),
errcontext("%s\nin PL/Tcl function \"%s\"",
UTF_U2E(Tcl_GetVar(interp, "errorInfo",
TCL_GLOBAL_ONLY)),
prodesc->user_proname)));

is machine-dependent, which explains why I didn't see it on HPPA.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2008-06-16 21:33:00 Re: pltcl broken on tcl8.5 ?
Previous Message David E. Wheeler 2008-06-16 19:45:57 Re: Question about Encoding a Custom Type