Re: fix log_min_duration_statement logic error

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix log_min_duration_statement logic error
Date: 2003-10-05 18:16:10
Message-ID: 7492.1065377770@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> I have not heard from you why we should make it harder (split across two
> lines), except for consistency with log_statement and log_duration
> outputs.

That is exactly my argument. I'll freely admit that it's not a strong
point, but I find the claim that the inconsistent formats will be easier
to parse to be a much weaker argument, in the absence of any attempt to
make them *actually* easier to parse (like really truly one line).

[ later ]
> Should we instead convert newlines to "\n" and output the query as a
> single line?

That would shore up your position considerably. It needs a little
thought as to whether this would induce any confusion, and whether we
really care if so.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Stephan Szabo 2003-10-05 18:40:10 Re: Open 7.4 items
Previous Message Bruce Momjian 2003-10-05 17:45:17 Re: fix log_min_duration_statement logic error