From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Andres Freund <andres(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review]) |
Date: | 2013-08-20 16:34:26 |
Message-ID: | 7370.1377016466@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Stephen Frost escribi:
>> While I really like the 'include auto.conf' style, I'm starting to think
>> it may not be workable after all. Another thing to consider is if the
>> user decides to change that include line.. What happens when the DBA
>> tries to do a 'ALTER SYSTEM'? It'd still use the hard-coded auto.conf
>> file and happily update it, I imagine, but it won't actually get
>> included...
> Well, this whole line of discussion started because I objected to the
> whole code path that was trying to detect whether auto.conf had been
> parsed, and raised a warning if ALTER SYSTEM was executed and the file
> wasn't parsed.
I really, really don't think that we should be trying to detect or prevent
any such thing. If the user breaks it like that, he gets to keep both
pieces --- and who's to say it's broken, anyway? Disabling ALTER SYSTEM
might have been exactly his intent.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Christopher Browne | 2013-08-20 16:38:37 | Re: Personal note: taking some vacation time in Sep/Oct |
Previous Message | Alvaro Herrera | 2013-08-20 16:32:10 | Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review]) |