| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Jason Petersen <jason(at)citusdata(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: [BUGS] Concurrent ALTER SEQUENCE RESTART Regression |
| Date: | 2017-06-01 17:08:33 |
| Message-ID: | 7345e39f-982a-130f-91a4-3d487e5de08c@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 01/06/17 16:51, Robert Haas wrote:
> On Wed, May 31, 2017 at 8:07 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> Here's a patch doing what I suggested above. The second patch addresses
>> an independent oversight where the post alter hook was invoked before
>> doing the catalog update.
>
> 0002 is a slam-dunk. I don't object to 0001 but haven't reviewed it carefully.
>
I did go over the code (ie didn't do actual testing), and I like it much
better than the current state. Both in terms of making the behavior more
consistent and the fact that the code is simpler.
So +1 to go ahead with both patches.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mike Palmiotto | 2017-06-01 18:13:43 | Re: BUG #14682: row level security not work with partitioned table |
| Previous Message | Tom Lane | 2017-06-01 16:22:53 | Re: BUG #14676: neqsel is NULL dumb |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2017-06-01 17:37:56 | Re: Get stuck when dropping a subscription during synchronizing table |
| Previous Message | Petr Jelinek | 2017-06-01 17:06:10 | Re: retry shm attach for windows (WAS: Re: OK, so culicidae is *still* broken) |