Re: WSAStartup() in libpq

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: WSAStartup() in libpq
Date: 2007-03-08 15:10:28
Message-ID: 7296.1173366628@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> So I suggest the following simple patch.. Any objections?

One wonders if we need DllMain() at all any more. We certainly don't
need that switch statement ...

Also, isn't the WSACleanup() in freePGconn in the wrong place? Seems
like it shouldn't be done until after we've closed the socket. I'd
be inclined to put it at the bottom of the routine.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2007-03-08 15:28:46 Re: WSAStartup() in libpq
Previous Message Pavan Deolasee 2007-03-08 12:43:25 Re: Bug in VACUUM FULL ?