Re: pgstat: remove delayed destroy / pipe:

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Peter Brant" <Peter(dot)Brant(at)wicourts(dot)gov>, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, <pgsql-patches(at)postgresql(dot)org>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pgstat: remove delayed destroy / pipe:
Date: 2006-05-02 08:13:31
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA35335@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> It turns out the problem is that port/pipe.c is compiled with
> -DFRONTEND and include/port/win32.h wraps the recv to
> pgwin32_recv macro in a #ifndef FRONTEND. We've actually
> been using the WinSock recv function directly (verified with gcc -E).

That's definitly wrong.
Looks like this file needs a _srv version in the Makefile. Bruce?

Just a thought - might this affect more things that rely on FRONTEND
defines in the headers? How bad would it be to just make libpgport build
two complete sets of object files, one for server and one for frontend,
instead of special-casing which files are rebuilt?

> If somebody else could take over actually fixing this, that
> would be great. As I mentioned before, we're heading away
> from Windows for the time being.

I can try - though I only have development servers on win32 these days,
and have never been bitten by this actual problem. So we'd still much
appreciate yuor help in testing a solution once it's there..

//Magnus

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Dhanaraj M 2006-05-02 10:19:23 Patch - Have psql show current values for a sequence
Previous Message Magnus Hagander 2006-05-02 07:46:45 Re: Building with Visual C++