Re: [HACKERS] Kerberos brokenness and oops question in 8.1beta2

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-hackers(at)postgresql(dot)org>, "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Kerberos brokenness and oops question in 8.1beta2
Date: 2005-10-08 15:09:36
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE92E70F@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> The point is I'm having a hard time seeing what the actual
> gain is in not changing it back. If the principal name
> mismatches, we're going to get rejected anyway, so it's not
> really a problem there. Even though the gain in changing it
> back isn't all that big either, why should we introduce
> abackwards-incompatibility if there is no real gain in a
> different part of the code.

Here's a patch that fixes the big problem and reverts the behaviour of
appl_version to be compatible with 8.0. It's easy enough to isolate the
changes that are around the appl_version - one line in
backend/libpq/auth.c call to krb5_recvauth and one in
interfaces/libpq/fe-auth.c call to krb5_sendauth.

The call in backend/libpq/auth.c to krb5_sname_to_principal in 8.1beta2
was completely broken for a scenario where you *didn't* use virtual
hosts, by setting pg_krb5_server to NULL... The call is needed there as
well.

//Magnus

Attachment Content-Type Size
krb5fix.patch application/octet-stream 3.2 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jaime Casanova 2005-10-08 15:51:14 avoid pulling up subquerys that contain volatile functions?
Previous Message Magnus Hagander 2005-10-08 14:02:29 Re: Kerberos brokenness and oops question in 8.1beta2

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-10-08 15:30:02 Re: [HACKERS] Patching dblink.c to avoid warning about open
Previous Message Joe Conway 2005-10-08 13:36:29 Re: [HACKERS] Patching dblink.c to avoid warning about