Re: pgsql: Arrange to set the LC_XXX environment variables to match our

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Arrange to set the LC_XXX environment variables to match our
Date: 2006-01-02 11:23:59
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE6C7E0E@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> > This patch appears to have killed win32 builds that *don't* have NLS
> > enabled:
>
> > pg_locale.c:109: error: `LC_MESSAGES' undeclared (first use in this
> > function)
>
> Silly me for assuming all WIN32 platforms are alike ;-)

Yes, indeed!
(LC_MESSAGES comes from libintl. Windows never supports it.)

> What's the appropriate behavior in this case --- just treat
> it as a no-op, as we do on Unix when LC_MESSAGES isn't defined?

Yes, I think that's correct.

//Magnus

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2006-01-02 16:45:12 pgsql: Remove the nexus between trial_buffs and trial_conns, and don't
Previous Message Bruce Momjian 2006-01-02 03:30:42 pgsql: Remove unnecessary assignment, per Tom.