From: | David Steele <david(at)pgmasters(dot)net> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz> |
Cc: | Vik Fearing <vik(at)2ndquadrant(dot)fr>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Ants Aasma <ants(dot)aasma(at)eesti(dot)ee>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Reviewing freeze map code |
Date: | 2016-05-18 12:41:25 |
Message-ID: | 648c400e-ff35-3f95-69cb-4a83f0158e7f@pgmasters.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 5/18/16 6:37 AM, Robert Haas wrote:
> On Tue, May 17, 2016 at 5:47 PM, Gavin Flower
> <GavinFlower(at)archidevsys(dot)co(dot)nz> wrote:
>> On 18/05/16 09:34, Vik Fearing wrote:
>>> On 17/05/16 21:32, Alvaro Herrera wrote:
>>>>
>>>> Is SCAN_ALL really the best we can do here? The business of having an
>>>> underscore in an option name has no precedent (other than
>>>> CURRENT_DATABASE and the like).
>>>
>>> ALTER DATABASE has options for ALLOW_CONNECTIONS, CONNECTION_LIMIT, and
>>> IS_TEMPLATE.
>>>
>>>> How about COMPLETE, TOTAL, or WHOLE?
>>>
>>> Sure, I'll play this game. I like EXHAUSTIVE.
>>
>> I prefer 'WHOLE', as it seems more obvious (and not because of the pun
>> relating to 'wholesomeness'!!!)
>
> I think that users might believe that they need VACUUM (WHOLE) a lot
> more often than they will actually need this option. "Of course I
> want to vacuum my whole table!"
>
> I think we should give this a name that hints more strongly at this
> being an exceptional thing, like vacuum (even_frozen_pages).
How about just FROZEN? Perhaps it's too confusing to have that and
FREEZE, but I thought I would throw it out there.
--
-David
david(at)pgmasters(dot)net
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-05-18 12:51:34 | Re: Reviewing freeze map code |
Previous Message | David Rowley | 2016-05-18 12:17:15 | Re: Parallel query and temp_file_limit |